Fix issue 17375: Use OPTIONAL_PIC in the test suite#1863
Fix issue 17375: Use OPTIONAL_PIC in the test suite#1863Burgos wants to merge 2 commits intodlang:masterfrom
Conversation
|
Thanks for your pull request, @Burgos! We are looking forward to reviewing it, and you should be hearing from a maintainer soon. Some tips to help speed things up:
Bear in mind that large or tricky changes may require multiple rounds of review and revision. Please see CONTRIBUTING.md for more information. Bugzilla references
|
Test suite didn't compile the executable with fPIC or with -cov no matter if that was set in the top makefile (since it is a) overriding DFLAGS, and b) because OPTIONAL_PIC was not exported from the main make file to sub make files). This makes test suite compile executables with the fPIC if requested with PIC. Incidentally, this fixes a problem compiling shared test suite on arch linux with binutils greater than v2.28 (see issue 17375), since the executable itself will be compiled with -fPIC, not just shared library. N.B.: the -cov flag is present, but not exported and used, because some shared library tests are segfaulting when compiled with -cov.
|
Edit: removed "Fix issue" annotation, since it just worksaround it so that testsuite may work. |
|
Added |
|
Bah, now I found out #1721 which is staled from December. :grumpy_cat:. Closing as duplicate, will reopen a new one with the |
2 participants
Test suite didn't compile the executable with fPIC or with -cov no
matter if that was set in the top makefile (since it is a) overriding
DFLAGS, and b) because OPTIONAL_PIC was not exported from the main make
file to sub make files).
This makes test suite compile executables with the fPIC if requested
with PIC. Incidentally, this fixes a problem compiling shared test suite
on arch linux with binutils greater than v2.28, since the executable
itself will be compiled with -fPIC, not just shared library.
N.B.: the -cov flag is present, but not exported and used, because
some shared library tests are segfaulting when compiled with -cov.